[Webkit-unassigned] [Bug 32596] Refactor Window object tests to use a shared list of property names

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 09:38:12 PST 2009


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #44945|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #7 from Darin Adler <darin at apple.com>  2009-12-16 09:38:12 PST ---
(From update of attachment 44945)
What this removes is any test that checks that no extra properties on the
Window object are present. I would like to see us add one test for that. It's
good not to have multiple tests for it, but I think it's good to have one to
help remind people to keep the list of window properties up to date. That test
can have whatever platform exceptions we need coded into it.

> -FAIL inner.isInner.isInner should be true. Was false.
> -FAIL inner.isInner.constructor.isInner should be true. Was false.

Is it a good thing to skip testing this? Should we add something back so this
case is tested?

> +staticWindowProperties = [

I think this should say "var staticWindowProperties" or "const
staticWindowProperties" for better efficiency.

> diff --git a/LayoutTests/fast/js/global-constructors.html b/LayoutTests/fast/js/global-constructors.html
> index d08d6f5..684a9ed 100644
> --- a/LayoutTests/fast/js/global-constructors.html
> +++ b/LayoutTests/fast/js/global-constructors.html
> @@ -7,6 +7,7 @@
>  <body>
>  <p id="description"></p>
>  <div id="console"></div>
> +<script src="../dom/resources/static-window-properties.js"></script>
>  <script src="script-tests/global-constructors.js"></script>
>  <script src="resources/js-test-post.js"></script>
>  </body>

Changing the test in this fashion means it should move into the fast/dom
directory. The old test could run in a non-browser context, so it made sense to
have it in fast/js, although we'd need different test results for that case.

I'm going to say r=me on this as-is, but ideally I'd like to see some
refinement and followup in future patches.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list