[Webkit-unassigned] [Bug 32214] Add WebSocket feature in Worker

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32214





--- Comment #16 from David Levin <levin at chromium.org>  2009-12-16 07:52:22 PST ---
(In reply to comment #11)
> > > diff --git a/WebCore/websockets/ThreadableWebSocketChannel.cpp b/WebCore/websockets/ThreadableWebSocketChannel.cpp
> > > +#endif  // ENABLE(WORKERS)
> > 
> > One space before end of line comments.
> 
> It seems there are no explicit rule about this but this is the consensus of
> core WebKit developers. Do you think we should note this rule in style guide
> explicitly and modify check-webkit-style?

Yes, see this email where I listed a number of things that there is consensus
on but nothing in the webkit style guide:
  http://lists.macosforge.org/pipermail/webkit-dev/2009-September/009807.html

Unfortunately, I haven't yet done the next step of adding these items to the
style guide, but there is consensus on them (see that thread for a few small
modifications to those guidelines).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.