[Webkit-unassigned] [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 22:34:19 PST 2009


--- Comment #11 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-15 22:34:19 PST ---
(In reply to comment #10)
> Failed to run
> "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply',
> '--reviewer', 'David Levin', '--force']" exit_code: 1
> Last 500 characters of output:
> tch.
> 9 out of 9 hunks ignored
> can't find file to patch at input line 5
> Perhaps you used the wrong -p or --strip option?
> The text leading up to this was:
> --------------------------
> |Index: Scripts/modules/cpp_style_unittest.py
> |===================================================================
> |--- Scripts/modules/cpp_style_unittest.py    (revision 52066)
> |+++ Scripts/modules/cpp_style_unittest.py    (working copy)
> --------------------------

It looks like this failed because the file paths are missing the WebKitTools
prefix.  Did I do something wrong?

For this change I only checked out the WebKitTools folder, using a command

svn checkout http://svn.webkit.org/repository/webkit/trunk/WebKitTools Tools1

(I also renamed Tools1 to something else after that.)  I ran svn-create-patch
from within that folder to create the patch.  Let me know the best way to
correct this.  I assume there is a convenient way to land patches that doesn't
require checking out the entire tree again?  (Generally, I would not mind
receiving advice on how to best manage working on multiple, possibly
overlapping changes at once.)  Thanks.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list