[Webkit-unassigned] [Bug 32592] New: [check-webkit-style] Refactor cpp_style.parse_arguments so that it has no global variable side effects.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 19:44:02 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32592

           Summary: [check-webkit-style] Refactor
                    cpp_style.parse_arguments so that it has no global
                    variable side effects.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P4
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: chris.jerdonek at gmail.com
                CC: eric at webkit.org, levin at chromium.org, hamaji at google.com


The function cpp_style.parse_arguments currently has side effects of setting
global variables (and also writing to sys.stderr).

Refactor parse_arguments so this doesn't happen.  This will make unit testing
easier and also make it more transparent when called from check-webkit-style.

I am working on this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list