[Webkit-unassigned] [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 19:13:19 PST 2009


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
  Attachment #44759|0                           |1
        is obsolete|                            |

--- Comment #9 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-15 19:13:18 PST ---
Created an attachment (id=44935)
 --> (https://bugs.webkit.org/attachment.cgi?id=44935)
Proposed patch 3

- Incorporated all of Dave and Shinichiro's comments.  This includes
  removing the addition of the guard clause to process_patch.
- Also added a code comment explaining the decision to use the "filter
  rule" terminology rather than "filter" for an individual boolean 
  filter item.

Thanks, guys, for taking the time to review this larger patch so quickly.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list