[Webkit-unassigned] [Bug 32589] New: bugzilla-tool create-bug throws exception on extra "enter" press

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32589

           Summary: bugzilla-tool create-bug throws exception on extra
                    "enter" press
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: ddkilzer at webkit.org, levin at chromium.org


bugzilla-tool create-bug throws exception on extra "enter" press

One has to be very careful in using bugzilla-tool create-bug not to hit "enter"
an extra time, or you get this:

37. XML DOM
Enter a number: Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 101, in
<module>
    BugzillaTool().main()
  File "/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line
252, in main
    return command.check_arguments_and_execute(args_after_command_name, self)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/multicommandtool.py", line
99, in check_arguments_and_execute
    return self.execute(command_options, command_args, tool) or 0
  File "/Projects/WebKit/WebKitTools/Scripts/modules/commands/upload.py", line
323, in execute
    self.create_bug_from_patch(options, args, tool)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/commands/upload.py", line
300, in create_bug_from_patch
    bug_id = tool.bugs.create_bug_with_patch(bug_title, comment_text,
options.component, diff_file, "Patch", cc=options.cc,
mark_for_review=options.review, mark_for_commit_queue=options.request_commit)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 394, in
create_bug_with_patch
    component = self.prompt_for_component(component_names)
  File "/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 366, in
prompt_for_component
    result = int(raw_input("Enter a number: ")) - 1
ValueError: invalid literal for int() with base 10: ''

We should handle that case and ask again on invalid input.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.