[Webkit-unassigned] [Bug 32559] [Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32559





--- Comment #5 from Andrei Popescu <andreip at google.com>  2009-12-15 11:45:10 PST ---
(In reply to comment #3)
> (From update of attachment 44889 [details])
> > Index: WebCore/platform/network/android/AuthenticationChallenge.h
> ...
> > +class ResourceHandle;
> 
> ^^^ This forward declaration is unnecessary.
> 

Removed.

> 
> > Index: WebCore/platform/network/android/Cookie.cpp
> 
> ^^^ This file should be named CookieJarAndroid.cpp to stick with conventions.
>

Done.

> 
> > +#include "config.h"
> > +
> 
> ^^^ please include CookieJar.h here.
>

Included.

> 
> > +#include "PlatformBridge.h"
> > +
> > +namespace WebCore {
> > +
> > +class Document;
> 
> ^^^ no need for Document forward declare if you include CookieJar.h

Removed.

Thanks,
Andrei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.