[Webkit-unassigned] [Bug 32559] [Android] Android needs implementation of setCookies, cookies and cookiesEnabled functions.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32559


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44889|review?                     |review-
               Flag|                            |




--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-12-15 11:30:10 PST ---
(From update of attachment 44889)
> Index: WebCore/platform/network/android/AuthenticationChallenge.h
...
> +class ResourceHandle;

^^^ This forward declaration is unnecessary.


> Index: WebCore/platform/network/android/Cookie.cpp

^^^ This file should be named CookieJarAndroid.cpp to stick with conventions.


> +#include "config.h"
> +

^^^ please include CookieJar.h here.


> +#include "PlatformBridge.h"
> +
> +namespace WebCore {
> +
> +class Document;

^^^ no need for Document forward declare if you include CookieJar.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.