[Webkit-unassigned] [Bug 28306] double-clicking a word inside <b> beside newline select two words

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=28306





--- Comment #25 from MORITA Hajime <morrita at gmail.com>  2009-12-15 06:11:28 PST ---
Thank you for reviewing quickly!
I've posted a revised patch.

> 
> Do we really need a typecast here? Does some compiler generate a warning
> without it? I'd prefer to see that omitted.
Fixed; It was redundant and safely removed. Thank you for pointing it out.

> The factoring here is a bit strange. The caller gets the renderer and then
> checks that it's a RenderText. But then it calls the function passing the
> Node*. Since it has done the type checking, it should pass a RenderText* in
> rather than a Node* the type checking and type casting should be in the same
> function.
Fixed. 

> I am not a huge fan of the name "iterable" here. It would be useful to write
> out a couple sentences explaining what the sentence does, and then maybe
> someone could extract some key words to come up with a good name for the
> function.
Agreed, and tried a little more verbose name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.