[Webkit-unassigned] [Bug 30914] [Qt] Javascript Prompt API default return values check failure on QtLauncher

Tue Dec 15 04:54:27 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=30914

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44845|review?                     |review+
               Flag|                            |

--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2009-12-15 04:54:27 PST ---
(From update of attachment 44845)
LGTM, but there are a few things you might consider changing.

> +++ b/WebCore/manual-tests/qt/java-script-prompt.html

The manual tests doesn't look Qt specific. Is it? If it is not, we should move
it.

> -    result should be written to \a result and true should be returned.
> +    result should be written to \a result and true should be returned. If the prompt was not cacelled by the

cancelled with an n. Please change this before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.