[Webkit-unassigned] [Bug 32538] [check-webkit-style] Add support for TAB check against text files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32538


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.jerdonek at gmail.com




--- Comment #6 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-15 00:42:00 PST ---
A couple high-level comments:

(1) The proposed text_style.process_file function has a lot of overlap with
cpp_style.process_file.  It might be worth creating a check_webkit_style.py
module and moving the cpp_style.process_file to that location.  We could do the
branching between file types there.  This will also allow us to keep additional
logic out of the check-webkit-style command-line wrapper.  Since the text-file
specific logic is minimal, for now you could keep it in check_webkit_style.py. 

(2) In general, I think we should aim to reduce the amount of logic in the
check-webkit-style file rather than add more.  We will have better test
coverage if we keep check-webkit-style as close to a command-line wrapper as
possible.  Note, for example, that the process_patch function which is getting
expanded is not currently covered by the tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.