[Webkit-unassigned] [Bug 32487] [check-webkit-style] cpp_style.py contains code redundant with check-webkit-style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32487


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.jerdonek at gmail.com




--- Comment #6 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-14 23:29:59 PST ---
(In reply to comment #5)
> (From update of attachment 44759 [details])
> Though I'm not a reviewer, I'd like to put some comments.
> 
> > +"""Does WebKit-lint on c++ files.
> 
> "on C/C++ files" would be better.

Note that I simply moved the existing string that was in cpp_style.py to
check-webkit-style.  I can change this though.

> >  def main():
> > -    cpp_style.use_webkit_styles()
> > +    cpp_style._DEFAULT_FILTER_RULES = cpp_style._WEBKIT_FILTER_RULES
> >  
> > -    (files, flags) = cpp_style.parse_arguments(sys.argv[1:], ["git-commit="])
> > +    (files, flags) = cpp_style.parse_arguments(sys.argv[1:], ["git-commit="], True)
> 
> I prefer display_help=True to True as the meaning becomes clearer in this way.

Note that this is only meant to be temporary.  I chose display_help=false for
now because there are many calls to parse_arguments in the test_parse_arguments
unit test that require the display to be suppressed.  I was planning to
refactor parse_arguments and its unit tests in my next patch for other reasons.
 That patch will eliminate the need for a display_help parameter entirely.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.