[Webkit-unassigned] [Bug 25877] bugs.webkit.org should have a patch size warning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 18:59:11 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=25877





--- Comment #8 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-14 18:59:10 PST ---
(In reply to comment #7)
> I'm not sure check-webkit-style is the best place for the check.

After thinking a bit more, I agree with you that check-webkit-style is not a
good place to check patch length.

There is an advantage, though, to having a warning appear as part of a script
that contributors already run. You can save time by catching the problem
earlier in the process than a bot can.

Another option is having svn-create-patch emit a warning through stderr.  This
way contributors would always receive a notification early on that their patch
is large.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list