[Webkit-unassigned] [Bug 32464] [bzt] Kill LandingSequence

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32464


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44728|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-12-14 16:17:43 PST ---
(From update of attachment 44728)
Now we'll need to test the input/output state of each command.  Seems this
would be easier to test if they were in fact exactly that.  input = {} and
output = {}.  Do we ever need output to persist across comamnds?  e.g. that
command1 produces output that command3 uses, but command2 ignores?  Donno.

Spacing?
 196         state = {"patch": patch}

I would have put spaces after { and before }... but maybe the PEP says
something here?  Also I would have put a space before :

Seems like Command should expose a run_and_handle_errors method, which calls
through to the _sequence method.

Looks OK though.  Would be good to figure out what the official spacing is
supposed to be, since your spacing here is inconsistent with at least the code
that I have written in modules/*.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.