[Webkit-unassigned] [Bug 32295] Typing in Wave repaints the whole screen

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32295


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|webkit-unassigned at lists.web |jamesr at chromium.org
                   |kit.org                     |
  Attachment #44772|0                           |1
        is obsolete|                            |
  Attachment #44772|review?                     |
               Flag|                            |
  Attachment #44825|                            |review?
               Flag|                            |




--- Comment #10 from James Robinson <jamesr at chromium.org>  2009-12-14 15:05:34 PST ---
Created an attachment (id=44825)
 --> (https://bugs.webkit.org/attachment.cgi?id=44825)
better patch and test

This patch is slightly better since it avoids doing another walk through the
RenderBlock's children.  I've also avoided changing when fullLayout is set in
preference for changing when the RenderBlock is mutated.

I'd greatly appreciate some input on what this code is supposed to be doing. 
There seem to be a lot of signals used to indicate that a RenderBlock needs to
have some or all of its lineboxes regenerated:

RenderBlock::m_needsLayout
RenderBlock::firstLineBox() == NULL
RenderText::m_linesDirty
InlineBox::m_dirty

but I can't figure out which should be set under which circumstances.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.