[Webkit-unassigned] [Bug 30000] [GStreamer] Check return values of gst_element_set_state()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 13:01:37 PST 2009


--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-12-14 13:01:37 PST ---
(From update of attachment 44519)
OK.  There is one slight change in logging behavior here, it won't log Play if
the switch to play fails.  I don't think that matters though.

Style violation:
 121             bool changePipelineState(GstState state);
we don't name arguments when the name doesn't add anything.

Shouldn't changePipelineState be private?

And why is it called "pipeline state"?

It would appear that this function only works for either PLAY or PAUSE, but I
don't see you asserting that anywhere.  You might want to ASSERT the inputs.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list