[Webkit-unassigned] [Bug 32511] Dragging an SVG image triggers assertion in DragController::startDrag()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32511


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44788|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2009-12-14 09:45:47 PST ---
(From update of attachment 44788)
Thanks, looks like the right fix.

> +        virtual String filenameExtension() const;

Virtual functions like this one normally should be private rather than public.
It's a programming error to call this function on a pointer known to be an
SVGImage* so it's good to get a compiler error in that case. And a private
member function still does just fine at overriding the base class.

Can we make a regression test for this? Normally we require regression tests
for all bug fixes, and we have quite a few dragging tests already, so it can
probably be done.

I'm going to say review-, but if you try and find we can't make a regression
test then revise the ChangeLog to explain why, and then feel free to put this
up for review again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.