[Webkit-unassigned] [Bug 32437] [Qt] [LayoutTestController]Output of document.write() is vanished by waitUntilDone()/notifyDone()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32437





--- Comment #19 from robert <robert at roberthogan.net>  2009-12-14 07:33:49 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > 
> > Layout tests can have multiple page loads so m_loadFinished needs to be set to
> > false every time a new one is started, this prevents NotifyDone from dumping
> > prematurely.
> 
> True, they can have multiple page loads. But they also can have a child
> windows, which is created in QWebPage *DumpRenderTree::createWindow().

I think this case is covered by the fact that I connect resetLoadFinished() to
QWebPage::loadStarted(). At least my testing here (before/after patch) doesn't
introduce any additional failed tests, apart from the two I mention in the
patch - and those two appear to be unrelated bugs masked by the current
behaviour of notifyDone.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.