[Webkit-unassigned] [Bug 32437] [Qt] [LayoutTestController]Output of document.write() is vanished by waitUntilDone()/notifyDone()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 14 06:32:35 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=32437
--- Comment #14 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2009-12-14 06:32:33 PST ---
(In reply to comment #12)
> Created an attachment (id=44789)
--> (https://bugs.webkit.org/attachment.cgi?id=44789) [details]
> Fix style error and renamed m_isLoading to m_hasDumped
>
> I think m_isLoading is better off named as m_hasDumped and set to false when
> the test starts. With the introduction of m_loadFinished, it's purpose is to
> check whether DRT still needs to dump the results or not.
ok then. is m_loadFinished needed then?
btw, I don't think we want to add methods for resetting all variables:
+ void resetLoadFinished() { m_loadFinished = false; }
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list