[Webkit-unassigned] [Bug 32437] [Qt] [LayoutTestController]Output of document.write() is vanished by waitUntilDone()/notifyDone()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32437





--- Comment #10 from Andras Becsi <abecsi at inf.u-szeged.hu>  2009-12-14 05:37:06 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Is there some reason you didn't fix these style nits?  They seem like true
> > positives to me:
> > 
> > +    }else if (!shouldWaitUntilDone()) {
> > 
> > [...]
> > 
> > +    if (!m_loadFinished) {
> > +        return;
> > +    }
> 
> They are, I missed the stylebot report when adding the changelog but have fixed
> them locally. Casba suggested yesterday on IRC that he would give the patch a
> roll on the Qt buildbot server and see if it confirmed my results. Once he's
> happy I'll re-upload.

>55 void LayoutTestController::reset()
>56 {
>57 m_isLoading = true;
>58 m_loadFinished = false; 

I think this is a dulication, because if we would refactor LayoutTestController
correctly then logically you only have m_loadFinished if m_isLoading is false,
so you do not need them both.

My plan is to refactor the whole DumpRenderTree in a way which looks at least
similar to the other ports implementation. I think leaving things as they are
and working around these problems only sweeps them under the carpet.

br,
bbandix

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.