[Webkit-unassigned] [Bug 32460] Regression: Web inspector deletes nodes when editing css

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32460





--- Comment #4 from Pavel Feldman <pfeldman at chromium.org>  2009-12-13 05:41:26 PST ---
Investigation note:

The reason is that Backspace is processed in handleKeyEvent that is now being
called from documents' global handler. So that if any control does not mute the
event via preventDefault/stopPropagation, it gets into the default handler and
is processed as a shortcut. As a result, any input field nukes selected element
on backspace when there is nothing to erase.

I was not familiar with our focus / key handling code before, so I explored it
a bit today and was quite surprised. In particular I learned that our tree
outline component is not focusable by design. And divs are not focusable by
design :) As a result, "Up" event on elements tree is being dispatched on
"main-panels" target. I think it is very wrong - it should be dispatched on
tree outline container instead.

Most of our panels / sidebars should be focusable and support keyboard
handling. It'd be also nice to have proper focus traversal policy when going
through the panel (like tab brings you from elements tree to the sidebar and
iterates over the styles / metrics / etc. containers there).

Can we make tree outline focusable by means of tabIndex or something similar?
We would then add explicit key listeners on right components and handle
everything the right way. handleKeyEvent on Panel would transform into
handleShortcut and would only be responsible for shortcuts, processing only
unhandled events.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.