[Webkit-unassigned] [Bug 32196] [Qt] createPlugin() should decide whether Qt Plugins can be created when pluginsEnabled is false

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32196





--- Comment #4 from robert <robert at roberthogan.net>  2009-12-12 02:29:52 PST ---
(In reply to comment #3)
> (From update of attachment 44363 [details])
> This patch should be written in a more platform-independent fashion with fewer
> #if statements.
> 
> 
> Then we need versions of isClientPluginMIMEType that return false on all the
> non-Qt platforms.
> 
> I'm not sure "client plug-in" is the best name for this concept, so you can use
> a better one if you can think of it.

Is 'isNativePluginMIMEType' OK?

Not sure about the unit tests to add - should I make the test available to all
platforms?  Or is it ok to just add it for Qt? My sense is that I need to add
it for all platforms but this means changes to nearly all the DRTs to add
support for a WebKitPluginsEnabled preference.

My related reservation is adding so much code for platforms I can't compile
myself - so the patch will only be tested on gtk and qt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.