[Webkit-unassigned] [Bug 32452] Port of v8 to work with Gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32452





--- Comment #22 from Michael Emmel <mike.emmel at gmail.com>  2009-12-12 00:38:35 PST ---
(In reply to comment #19)
> BTW, the v8 conflicting with X headers thing has also been a problem for Chrome
> -- we have a few files where we have to jack around the include order.  (Now
> that I write this I am unclear where a file would use v8 and X11 at the same
> time, but IIRC it is because plugins use NPAPI which needs X and they also call
> v8 functions.)
> 
> It would have been nice for X to not have used True and False and if you have a
> time machine to fix that 10 years ago I would do it.  Since we can control
> where v8 is included, one option might be to "#define True V8True" around where
> you include that.
> 
> GTK normally doesn't need X headers; it's only gdkx.h that does.  So you could
> also do ifdef hacks around in the files that only touch those two.

Correct the NSAPI header had to be hacked in Chrome because of this. Also this
is the one place in Chrome where you have collision.

As to your next statement thats not correct "GTK normally doesn't need X
headers"
they are certainly included in the deep include chain in gtk. Actually gdk but
its a chain of includes that lead to X11.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.