[Webkit-unassigned] [Bug 32461] Adding QPixmap/QImage support for the Qt hybrid layer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 23:56:23 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32461


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #1 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-11 23:56:23 PST ---
Attachment 44725 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/qt/tests/hybridPixmap/widget.cpp:1:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.cpp:3:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.cpp:15:  Missing space after , 
[whitespace/comma] [3]
WebKit/qt/tests/hybridPixmap/widget.cpp:20:  Missing space after , 
[whitespace/comma] [3]
WebKit/qt/tests/hybridPixmap/widget.cpp:21:  Missing space after , 
[whitespace/comma] [3]
WebKit/qt/tests/hybridPixmap/widget.cpp:26:  Missing space after , 
[whitespace/comma] [3]
WebKit/qt/tests/hybridPixmap/widget.cpp:27:  Missing space after , 
[whitespace/comma] [3]
WebKit/qt/tests/hybridPixmap/widget.cpp:31:  Extra space before ( in function
call  [whitespace/parens] [4]
WebKit/qt/tests/hybridPixmap/widget.cpp:35:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.cpp:45:  Extra space before ( in function
call  [whitespace/parens] [4]
WebKit/qt/tests/hybridPixmap/widget.cpp:52:  Missing space after , 
[whitespace/comma] [3]
WebCore/bridge/qt/qt_runtime.cpp:53:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bridge/qt/qt_runtime.cpp:54:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bridge/qt/qt_runtime.cpp:56:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bridge/qt/qt_runtime.cpp:58:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bridge/qt/qt_runtime.cpp:61:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.h:5:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.h:6:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/widget.h:8:  Code inside a namespace should not be
indented.  [whitespace/indent] [4]
WebKit/qt/tests/hybridPixmap/widget.h:18:  Extra space before ( in function
call  [whitespace/parens] [4]
WebKit/qt/tests/hybridPixmap/widget.h:20:  Extra space before ( in function
call  [whitespace/parens] [4]
WebKit/qt/tests/hybridPixmap/main.cpp:1:  Found other header before WebCore
config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit/qt/tests/hybridPixmap/main.cpp:2:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/tests/hybridPixmap/main.cpp:20:  This { should be at the end of the
previous line  [whitespace/braces] [4]
WebKit/qt/tests/hybridPixmap/main.cpp:22:  Declaration has space between type
name and * in Widget *wdg  [whitespace/declaration] [3]
WebKit/qt/tests/hybridPixmap/main.cpp:25:  Use 0 instead of NULL. 
[readability/null] [5]
Total errors found: 26

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list