[Webkit-unassigned] [Bug 32452] Port of v8 to work with Gtk webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32452





--- Comment #10 from Michael Emmel <mike.emmel at gmail.com>  2009-12-11 18:18:41 PST ---
(In reply to comment #9)
> Is there some reason #undef can't solve the pre-processor problem?  I'd be very
> surprised if V8 took the renaming patch.  That sounds like the biggest problem
> you'll need to solve to unblock this effort.

Yes I don't control the header include order.
the undef hack only works with simple include cycles the more complex ones make
it practically impossible to insert a undef in the correct place.

I would not have done what I did if it was possible to do it a different way in
any sane manner. Consider the header import  graph and I hope you can see it
ends in cycles that make cutting impossible without significant refactoring of
the code base which also would block the effort.

Its a catch-22 situation.

Its fairly easy to cause the problems simply reverse the definitions a second
time in the v8.h header.

I can do that and post the errors.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.