[Webkit-unassigned] [Bug 31802] Switch Chrome on Mac to Core Text APIs

Fri Dec 11 16:41:10 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=31802

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44532|review?                     |review+
               Flag|                            |

--- Comment #23 from Eric Seidel <eric at webkit.org>  2009-12-11 16:41:09 PST ---
(From update of attachment 44532)
I dont' think the ALWAYS_INLINE actually does anything here:
 90         ALWAYS_INLINE CFIndex indexAt(size_t i) const;

One of these days we should change these to take an ENUM which is RTL vs. LTR,
as that would make all the callsites easier to read:
 101         void createTextRunFromFontDataATSUI(bool ltr);
(Yes, totally out of scope for this patch.)

In general this looks fine.  It would be nice to see mitz's stamp of approval
on this, but I feel pretty confident this is correct.

Lets give mitz a few days to comment in case he's just been swamped.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.