[Webkit-unassigned] [Bug 32401] ifdefs for FreeBSD/OpenBSD

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32401





--- Comment #4 from pvalchev at google.com  2009-12-11 13:46:34 PST ---
(In reply to comment #2)
> (From update of attachment 44651 [details])
> > +++ JavaScriptCore/ChangeLog	(working copy)
> > @@ -1,3 +1,9 @@
> > +2009-12-10  Peter Valchev <pvalchev at google.com>
> > +        Add OpenBSD ifdefs
> 
> You need a newline between the above two lines, here and elsewhere.
> You should put a reference to this bug into your changelogs.

Done

> > +++ WebCore/page/EventHandler.cpp	(working copy)
> > @@ -1791,7 +1791,7 @@
> >      return swallowEvent;
> >  }
> >  
> > -#if !PLATFORM(GTK) && !(PLATFORM(CHROMIUM) && PLATFORM(LINUX))
> > +#if !PLATFORM(GTK) && !(PLATFORM(CHROMIUM) && (PLATFORM(LINUX) || PLATFORM(FREEBSD) || PLATFORM(OPENBSD)))
> 
> I fear we're going to need some sort of shared platform here.
> The OS_NIX question again!

Sure, although there aren't that many, so maybe this can be considered at a
later point? :)

> > -#elif defined(__linux__)
> > +#elif defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
> >  #include "FontPlatformDataLinux.h"
> 
> I guess this file needs to be renamed, huh?

Posix? :) But that sort of brings back the previous problem...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.