[Webkit-unassigned] [Bug 32326] Refactor some security code out of V8 bindings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 13:09:00 PST 2009


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #44696|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #10 from Adam Barth <abarth at webkit.org>  2009-12-11 13:08:59 PST ---
(From update of attachment 44696)
This looks like a great first step.  I've noted a few formatting issues below. 
There are a couple of things that I'm not sure how they'll scale up when we
convert more of the bindings, but they're fine for now.  We can revisit them if
the code isn't growing the right direction.

+ template <class Binding> class BindingSecurity {

I think we'd prefer

+ template <class Binding>
+ class BindingSecurity {

(meaning a line break)

+ class BindingSecurityHelper

I'm not entirely sold on this class.  We might need to see more examples to see
what the best general pattern is for this kind of thing.

+ typedef BindingSecurity<V8Binding> V8BindingSecurity;

I'm also not sure how this will scale.  It's fine here though.

+ template <> class State<V8Binding> : public State<GenericBinding> {

We'd also like a line break here.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list