[Webkit-unassigned] [Bug 32401] ifdefs for FreeBSD/OpenBSD

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 11:09:28 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32401





--- Comment #2 from Evan Martin <evan at chromium.org>  2009-12-11 11:09:28 PST ---
(From update of attachment 44651)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,9 @@
> +2009-12-10  Peter Valchev <pvalchev at google.com>
> +        Add OpenBSD ifdefs

You need a newline between the above two lines, here and elsewhere.
You should put a reference to this bug into your changelogs.

> +++ WebCore/page/EventHandler.cpp	(working copy)
> @@ -1791,7 +1791,7 @@
>      return swallowEvent;
>  }
>  
> -#if !PLATFORM(GTK) && !(PLATFORM(CHROMIUM) && PLATFORM(LINUX))
> +#if !PLATFORM(GTK) && !(PLATFORM(CHROMIUM) && (PLATFORM(LINUX) || PLATFORM(FREEBSD) || PLATFORM(OPENBSD)))

I fear we're going to need some sort of shared platform here.
The OS_NIX question again!


> -#elif defined(__linux__)
> +#elif defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__)
>  #include "FontPlatformDataLinux.h"

I guess this file needs to be renamed, huh?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list