[Webkit-unassigned] [Bug 32389] [v8] refactor WeakReferenceMap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32389





--- Comment #6 from anton muhin <antonm at chromium.org>  2009-12-11 06:20:26 PST ---
(In reply to comment #3)
> (From update of attachment 44633 [details])
> Wow, this looks great.  I didn't consider using the visitor interface
> internally, but it makes for some prettier code.
> 
> + virtual bool removeIfPresent
> + virtual void clear
> 
> Do these need to be virtual?  It doesn't look like they need to be overridden.

If we're lucky, they would be overridden. But conditionals are not for SVN,
removing.

Thanks a lot for review.If we're lucky, they would be overridden. But
conditionals are not for SVN, removing.

Thanks a lot for review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.