[Webkit-unassigned] [Bug 32389] [v8] refactor WeakReferenceMap

Thu Dec 10 12:46:30 PST 2009

https://bugs.webkit.org/show_bug.cgi?id=32389

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44633|review?                     |review+
               Flag|                            |

--- Comment #3 from Adam Barth <abarth at webkit.org>  2009-12-10 12:46:30 PST ---
(From update of attachment 44633)
Wow, this looks great.  I didn't consider using the visitor interface
internally, but it makes for some prettier code.

+ virtual bool removeIfPresent
+ virtual void clear

Do these need to be virtual?  It doesn't look like they need to be overridden.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.