[Webkit-unassigned] [Bug 32335] [v8] in Debug builds create an additional handle scope when doing debug build checks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32335





--- Comment #4 from anton muhin <antonm at chromium.org>  2009-12-10 05:36:14 PST ---
(In reply to comment #3)
> (From update of attachment 44551 [details])
> Seems like the ASSERTS can be outside of the #ifdef.

Technically yes.  However, if I remember it right, one can compile WebKit w/
asserts, but in Release mode, so we'll be in the trouble anyway.

Having said that, I'd easily adjust.

> How much does it cost to create the handle scope unconditionally?  I'd rather not have NDEBUG everywhere....

That's a hot path, and handle scope is only needed due to ASSERTS, so I'd
rather not spend a CPU cycle on it.  If you don't mind.

> Can we create the handle scope at a lower level where we're
> already splitting on NDEBUG?

Yes, for maybeDOMWrapper, but there is this type check, alas.

Overall, I wholeheartedly agree those NDEBUG are ugly.  So just let me know how
you'd like that to be arranged.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.