[Webkit-unassigned] [Bug 32334] [GTK] Should provide an API to control the IconDatabase

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32334


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #5 from Eric Seidel <eric at webkit.org>  2009-12-09 13:34:07 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > Attachment 44549 [details] [details] did not pass style-queue:
> > 
> > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> > WebKit/gtk/webkit/webkitwebview.cpp:2398:  Use 0 instead of NULL. 
> > [readability/null] [5]
> > WebKit/gtk/webkit/webkitwebview.cpp:4003:  Use 0 instead of NULL. 
> > [readability/null] [5]
> > WebKit/gtk/webkit/webkitprivate.cpp:262:  Use 0 instead of NULL. 
> > [readability/null] [5]
> 
> This is caused by our convention that NULL should be used for any calls gcc
> checks for the sentinel, and for code inside WebKit/gtk/.
> 
> > WebKit/gtk/webkit/webkitwebview.h:371:  Extra space before ( in function call 
> > [whitespace/parens] [4]
> > Total errors found: 4
> 
> This is caused by the GTK+ API convention of using vertical alignment for
> parameters. Any .h inside WebKit/gtk/webkit/ will have that.

If you believe check-webkit-style is wrong here, please file a bug an CC Dave
Levin and Adam Barth.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.