[Webkit-unassigned] [Bug 32165] WebSocket errors should be logged to console
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 9 08:45:12 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=32165
--- Comment #9 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2009-12-09 08:45:11 PST ---
(From update of attachment 44508)
Some feedback on the error strings:
> +++ b/WebCore/websockets/WebSocketChannel.cpp
...
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "Error in sending handshake message.", 0, m_handshake.clientOrigin());
nit: "Error sending handshake message."
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, String::format("Too long WebSocket frame %d", m_bufferSize + len), 0,
nit: "WebSocket frame (at %d bytes) is too long."
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "short server handshake: " + String(header, len), 0, clientOrigin());
nit: Start with an upper case letter? "Short server handshake:"
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "no response code found: " + String(header, len), 0, clientOrigin());
nit: Start with an upper case letter? "No response code found:"
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "Mismatch origin: " + clientOrigin() + " != " + m_wsOrigin, 0, clientOrigin());
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "Mismatch location: " + clientLocation() + " != " + m_wsLocation, 0, clientOrigin());
> + m_context->addMessage(InspectorControllerDestination, JSMessageSource, LogMessageType, ErrorMessageLevel, "Mismatch protocol: " + m_clientProtocol + " != " + m_wsProtocol, 0, clientOrigin());
nit: "Origin mismatch" or "Mismatched origin"
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list