[Webkit-unassigned] [Bug 32284] move code generation portions of Nodes.cpp to bytecompiler directory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32284


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-08 13:03:38 PST ---
Attachment 44479 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
JavaScriptCore/bytecompiler/NodesCodegen.cpp:27:  You should add a blank line
after implementation file's own header.  [build/include_order] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:30:  Alphabetical sorting problem.
 [build/include_order] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:270:  A case label should not be
indented, but line up with its switch statement.  [whitespace/indent] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:538:  One line control clauses
should not use braces.  [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:552:  One line control clauses
should not use braces.  [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:575:  One line control clauses
should not use braces.  [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:598:  One line control clauses
should not use braces.  [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1066:  A case label should not be
indented, but line up with its switch statement.  [whitespace/indent] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1121:  One line control clauses
should not use braces.  [whitespace/braces] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1269:  An else statement can be
removed when the prior "if" concludes with a return, break, continue or goto
statement.  [readability/control_flow] [4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1753:  min_num is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
JavaScriptCore/bytecompiler/NodesCodegen.cpp:1754:  max_num is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
Total errors found: 12

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.