[Webkit-unassigned] [Bug 31639] Add asserts to RefCounted to make sure ref/deref happens on the right thread.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31639


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Dmitry Titov <dimich at chromium.org>  2009-12-08 12:28:26 PST ---
(In reply to comment #8)
> (From update of attachment 44423 [details])
> The only thing I don't like about this is the name of
> disableThreadVerification. I would prefer a name that describes the threading
> regime being used rather than a simple "disable" call. But since the number of
> callers is extremely small at this time, it seems we can change this later.

Agreed.

> I'd eventually like to see the cross-thread string use be turned on, not in the
> allocation of the StringImpl, but at the call sites. I know the class is used
> cross thread "everywhere", but I think eventually we could do that. There are
> tons of strings where it would be good to have the main thread assertion work.

Added FIXME to StringImpl, will experiment with enforcing checks since we
should be able to use crossThreadString in those cases.

..
> We use one space after a period, nottwo.
..
> We'd normally put the braces on separate lines.
..
> I'd like to see a comment at all the disableThreadVerification call sites about
> why this needs to be done.

Fixed those and landed: http://trac.webkit.org/changeset/51869

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.