[Webkit-unassigned] [Bug 32248] [Chromium]: Issue with setting selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32248


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44435|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2009-12-07 15:58:34 PST ---
(From update of attachment 44435)
Since the WebKit bug links to the Chromium bug, I think it is
sufficient to just include the WebKit bug link in the ChangeLog.


> Index: WebKit/chromium/src/WebFrameImpl.cpp
...
>          if (node && node != frame()->document()) {
>              // Found a focusable parent node. Set focus to it.
>              frame()->document()->setFocusedNode(node);
> +            return;
>          } else {

nit: now that have the return statement, please remove the else
statement so that you can reduce the indentation of the following
code.

R=me otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.