[Webkit-unassigned] [Bug 32248] [Chromium]: Issue with setting selection

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32248





--- Comment #3 from Ojan Vafai <ojan at chromium.org>  2009-12-07 15:04:46 PST ---
(From update of attachment 44435)
> Index: WebKit/chromium/src/WebFrameImpl.cpp
> ===================================================================
> --- WebKit/chromium/src/WebFrameImpl.cpp	(revision 51798)
> +++ WebKit/chromium/src/WebFrameImpl.cpp	(working copy)
> @@ -1669,6 +1669,7 @@ void WebFrameImpl::setFindEndstateFocusA
> +        // No node related to the active match was focusable, so set the
> +        // active match as the selection (so that when you end the Find session,
> +        // you'll have the last thing you found highlighted) and make sure that
> +        // we have nothing focused (otherwise you might have text selected but
> +        // a link focused, which is weird).
> +        frame()->selection()->setSelection(m_activeMatch.get());
> +        frame()->document()->setFocusedNode(0);

Doesn't setSelection already set the focus appropriately? e.g. if you set the
selection to some text inside a link, shouldn't the link be focused?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.