[Webkit-unassigned] [Bug 32247] [GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 7 14:48:57 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32247


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-07 14:48:57 PST ---
Attachment 44433 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/tests/testwebframe.c:158:  test_webkit_web_frame_response is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit/gtk/tests/testwebframe.c:160:  Declaration has space between * and
variable name in WebKitWebFrame* frame  [whitespace/declaration] [3]
WebKit/gtk/tests/testwebframe.c:161:  Declaration has space between * and
variable name in WebKitNetworkResponse* response  [whitespace/declaration] [3]
WebKit/gtk/webkit/webkitwebframe.cpp:1158: 
webkit_web_frame_get_network_response is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/webkit/webkitwebframe.cpp:1162:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/gtk/webkit/webkitwebframe.cpp:1166:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/gtk/webkit/webkitwebframe.h:176:  Extra space before ( in function call 
[whitespace/parens] [4]
WebKit/gtk/tests/testmimehandling.c:109:  Declaration has space between * and
variable name in WebKitNetworkResponse* response  [whitespace/declaration] [3]
WebKit/gtk/tests/testmimehandling.c:110:  Declaration has space between * and
variable name in SoupMessage* message  [whitespace/declaration] [3]
WebKit/gtk/tests/testmimehandling.c:111:  Declaration has space between * and
variable name in char* disposition  [whitespace/declaration] [3]
Total errors found: 10

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list