[Webkit-unassigned] [Bug 31187] Get rid of phase argument to Image::drawPattern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31187





--- Comment #3 from Dirk Schulze <krit at webkit.org>  2009-12-07 13:16:17 PST ---
(In reply to comment #2)
> (disclaimer: the patch doesn't apply anymore since the colorspace stuff landed)
> 
> And yeah, we should probably do a cairo_pattern_status() before doing the
> cairo_set_source() to avoid bad matrices putting the cairo_t into an error
> state. The current check is not very good, because it just catches one special
> case.
> Although that won't protect us when only the context's tansform plus the
> pattern's transform ens up being bad.
> Solving that problem correctly requires work in Cairo.
> And a testcase exposing it. :/

One possibiliy is, to make every transformation to TransformationMatrix&
patternTransform and check if it is invertible (.isInvertible()) before we
transform the pattern. Nevertheless, I would like to see this with this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.