[Webkit-unassigned] [Bug 20261] Support Array and String generic shorthands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20261





--- Comment #5 from Patrick Mueller <pmuellr at yahoo.com>  2009-12-07 11:31:19 PST ---
As my first foray into the JSC impl, I've hacked these in by adding the methods
to ArrayConstructor.cpp (copying the pattern from DateConstructor.cpp).  I only
did one method, just see if it actually worked; it did.  I copied the map()
code from ArrayPrototype.cpp, changing as needed.

But clearly that's not The Right Thing To Do.  Wondering what is:

- copy the relevant functions into a separate cpp, making them externs, and
then having ArrayPrototype and ArrayConstructor call into them?

- copy the relevant functions into a .h file as inline, using that .h file in
the relevant .cpps?

- lazily lookup the existing ArrayPrototype calls out of the lut.h table, and
in the ArrayConstructor code, munge the args and call into the original
functions.

- something else

Guess I should also ask if I should even bother.  If I get these implemented in
an agreeable fashion, would we even add these methods to Array?  Is there some
religious or technical reason we wouldn't?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.