[Webkit-unassigned] [Bug 32178] Need to test that WebSocket protocol argument works

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32178


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44381|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2009-12-07 09:54:16 PST ---
(From update of attachment 44381)
> +// Failes if protocol is an empty string.

Spelling error here, "Fails" or "Failures" would be right, but "Failes" is
wrong.

> +// Failes if protocol contains an character less than U+0021.
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "sub protocol")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u0009")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u000A")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u000D")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u001B")');

Seems this should have a test for the character "\u0000".

> +// Fails if protocol containns an character greater than U+007F.
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u0080")');
> +shouldThrow('new WebSocket("ws://127.0.0.1:8880/simple", "\u3042")');

I’d like to see some special characters covered here like \uFFFF, \uFEFF,
\uFFFE, and surrogate pairs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.