[Webkit-unassigned] [Bug 29005] The values of RuntimeArray are not enumerable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 7 09:42:33 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=29005


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44394|review?                     |review+
               Flag|                            |




--- Comment #19 from Darin Adler <darin at apple.com>  2009-12-07 09:42:33 PST ---
(From update of attachment 44394)
> +    const unsigned int length = getLength();

On the next line of code you use "unsigned" but here you used "unsigned int".

Further, you mark this local variable "const" and we don't do that in WebKit.
There are so many that could be marked const, and I don't think we want to
start heading that direction now.

r=me despite this slight strangeness

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list