[Webkit-unassigned] [Bug 32193] New: [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 6 08:47:49 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32193

           Summary: [check-webkit-style] False positive for
                    DEFINE_OPCODE(op_jtrue) {
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abarth at webkit.org
                CC: eric at webkit.org, mjs at apple.com, levin at chromium.org


DEFINE_OPCODE(op_jtrue) {

generates the warning

JavaScriptCore/interpreter/Interpreter.cpp:2650:  Place brace on its own line
for function definitions.  [whitespace/braces] [4]

However, this is a false positive
<https://bugs.webkit.org/show_bug.cgi?id=32190#c8> because this is some sort of
macro.  Maybe we should notice the ALL CAPS "function" name and skip the brace
check?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list