[Webkit-unassigned] [Bug 31187] Get rid of phase argument to Image::drawPattern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31187





--- Comment #1 from Dirk Schulze <krit at webkit.org>  2009-12-05 23:48:13 PST ---
The changes look reasonable to me. I would like to know, why phase was
introduced? Oliver, do you know more about this?

> +    TransformationMatrix patternTransform = TransformationMatrix().translate(oneTileRect.x(), oneTileRect.y()).scaleNonUniform(scale.width(), scale.height());

I would like to see the transformations in two lines. Makes reading the code
easier.
The ChangeLog needs the link to the bug report too.

Also did you check canvas examples like
http://yuiblog.com/assets/slicing/slicing_test.html , or duke 3d? I had to
check phase for NaN, otherwise the Cairo port crashed, or stop further
rendering (I guess it's a problem of Cairo and handling not invertible
matrices).

I'll run pixeltests on Mac, if there are no reasons for phase.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.