[Webkit-unassigned] [Bug 32179] fixes to build-webkit --chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32179


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44341|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-12-04 17:45:57 PST ---
(From update of attachment 44341)
52             # We can't turn on warnings on Windows and Linux until we're
upstream the
5053             # WebKit API.

That comment change is wrong.
"we" or "we've" would work, but "we're" is wrong.

These seem like unrelated changes.  Or at lease could be landed separately.

I'm not sure I understand the need for buildChromiumVisualStudioProject as a
fork from buildVisualStudioProject

I'm also not sure if there is code to be shared with buildChromiumMakefile ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.