[Webkit-unassigned] [Bug 32176] Test that an image's size is valid before reading it.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 4 15:45:55 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=32176
Darin Adler <darin at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #44338|review? |review-
Flag| |
--- Comment #2 from Darin Adler <darin at apple.com> 2009-12-04 15:45:56 PST ---
(From update of attachment 44338)
> // Zero-height images can cause problems for some ports. If we have an
> // empty image dimension, just bail.
> - if (size().isEmpty())
> + if (isSizeAvailable() && size().isEmpty())
> return 0;
This changes the logic. If the size is not available, this now continues and
creates a native image. But the old code would return 0 if the size was not
available. You should reverse the logic.
if (!isSizeAvailable() || ...
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list