[Webkit-unassigned] [Bug 31390] Implement run-webkit-websocketserver
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 4 12:41:08 PST 2009
https://bugs.webkit.org/show_bug.cgi?id=31390
Alexey Proskuryakov <ap at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #44289|review?, commit-queue? |review+, commit-queue-
Flag| |
--- Comment #15 from Alexey Proskuryakov <ap at webkit.org> 2009-12-04 12:41:07 PST ---
(From update of attachment 44289)
Thanks for updating the patch!
> +# Note: This script must be run from WebKit directory.
I don't think that there is a good reason for this limitation. Why not use
webkitdirs.pm to make it work from any directory, like all our scripts do?
> + # wss is disabled until all platforms support pyOpenSSL.
> + # close WEBSOCKETSECURESERVER_IN;
> + # close WEBSOCKETSECURESERVER_OUT;
> + # close WEBSOCKETSECURESERVER_ERR;
> + # kill 15, $webSocketSecureServerPID;
This needs to be removed prior to landing.
> + $isWebSocketServerOpen = 0;
Tracking the state seems superfluous - there is no way for
openWebSocketServerIfNeeded to be called twice in this script, and no way for
it to be called after closing.
r=me, but please fix the script to work from any directory. And this patch
cannot be landed by commit-queue, because commented out code needs to be
removed.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list