[Webkit-unassigned] [Bug 29912] Avoid zero division during SVGPaintServerPattern::setup()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29912


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #40344|review?                     |review-
               Flag|                            |




--- Comment #12 from Dirk Schulze <krit at webkit.org>  2009-12-04 11:13:54 PST ---
(From update of attachment 40344)
The patch looks great.

> Index: WebCore/ChangeLog
...
> +
> +        Fix a Chromium SVG crash when visiting
> +        http://upload.wikimedia.org/wikipedia/commons/c/c2/World_map_pol_2005_v02.svg
> +        as reported by
> +        http://crbug.com/14521
> +
> +        The issue is tileRect is not empty with Skia when tileWidth or tileHeight becomes
> +        zero, and the calculation of numY or numX causes a zero division.
> +
> +        * svg/graphics/SVGPaintServerPattern.cpp:
> +        (WebCore::SVGPaintServerPattern::setup):

The discription doesn't adress the main problem: the zero division in
SVGPaintServerPattern. I don't see a connection between the fix, the problem
and the comment about Skia. Please add the topic of the bug and the link to the
bug report at the beginning of the Changelog.

r- for the Changelog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.