[Webkit-unassigned] [Bug 31395] Bugzilla should show images in git patches

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 07:52:12 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=31395





--- Comment #14 from Shinichiro Hamaji <hamaji at chromium.org>  2009-12-04 07:52:11 PST ---
I updated my patch. The new patch uses git as suggested by David (thanks!). I
couldn't find a git command to extract a file from git binary patch, so my
patch does:

1. Use Tempfile to create a unique name.
2. Append ".bin" to the filename so that the file doesn't exist.
3. Create a git patch which creates a new file using the filename we've got.
4. Use git-apply to extract the image file.
5. Read the contents of the image created.
6. Remove the file we've created.

So, this patch depends /tmp is writable. Can PrettyPrint.rb create a file in
/tmp? If not, I will need to figure out another way...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list